Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETCM-8250 test update d param #234

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Conversation

ladamesny
Copy link
Contributor

@ladamesny ladamesny commented Nov 14, 2024

Description

Add your description here, if it fixes a particular issue please provide a
link
to the issue.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages.
  • New tests are added if needed and existing tests are updated.
  • Relevant logging and metrics added
  • CI passes. See note on CI.
  • Any changes are noted in the changelog.md for affected crate
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG Partner Chains developers to do this
for you.

@ladamesny ladamesny self-assigned this Nov 14, 2024
@ladamesny ladamesny added the E2E-tests E2E Tests for SDET review/approval label Nov 14, 2024
@ladamesny
Copy link
Contributor Author

Replaces this PR on sidechains-tests: https://github.com/input-output-hk/sidechains-tests/pull/318

@ladamesny ladamesny closed this Nov 19, 2024
@ladamesny ladamesny deleted the ETCM-8250/test-update-d-param branch November 19, 2024 12:50
@ladamesny ladamesny restored the ETCM-8250/test-update-d-param branch November 19, 2024 13:58
@ladamesny ladamesny reopened this Nov 19, 2024
E2E-tests/config/api_config.py Outdated Show resolved Hide resolved
E2E-tests/config/substrate/devnet_nodes.json Outdated Show resolved Hide resolved
E2E-tests/config/substrate/local_nodes.json Outdated Show resolved Hide resolved
E2E-tests/config/substrate/staging_nodes.json Outdated Show resolved Hide resolved
E2E-tests/src/sidechain_main_cli.py Outdated Show resolved Hide resolved
E2E-tests/src/sidechain_main_cli.py Outdated Show resolved Hide resolved
E2E-tests/tests/committee/test_committee.py Outdated Show resolved Hide resolved
E2E-tests/config/substrate/devnet_nodes.json Outdated Show resolved Hide resolved
E2E-tests/config/substrate/devnet_nodes.json Outdated Show resolved Hide resolved
E2E-tests/config/api_config.py Outdated Show resolved Hide resolved
E2E-tests/tests/committee/test_committee.py Outdated Show resolved Hide resolved
E2E-tests/tests/committee/test_committee.py Outdated Show resolved Hide resolved
E2E-tests/src/sidechain_main_cli.py Outdated Show resolved Hide resolved
E2E-tests/src/blockchain_api.py Outdated Show resolved Hide resolved
E2E-tests/tests/committee/test_committee.py Show resolved Hide resolved
E2E-tests/tests/committee/test_committee.py Outdated Show resolved Hide resolved
E2E-tests/config/api_config.py Outdated Show resolved Hide resolved
E2E-tests/config/substrate/staging_nodes.json Outdated Show resolved Hide resolved
@ladamesny ladamesny force-pushed the ETCM-8250/test-update-d-param branch 2 times, most recently from ff619bb to e4a1070 Compare November 25, 2024 12:47
E2E-tests/tests/committee/test_committee.py Outdated Show resolved Hide resolved
E2E-tests/config/substrate/devnet_nodes.json Outdated Show resolved Hide resolved
E2E-tests/config/api_config.py Outdated Show resolved Hide resolved
E2E-tests/tests/committee/test_committee.py Outdated Show resolved Hide resolved
E2E-tests/tests/committee/test_committee.py Outdated Show resolved Hide resolved
E2E-tests/tests/committee/test_committee.py Outdated Show resolved Hide resolved
E2E-tests/config/api_config.py Outdated Show resolved Hide resolved
E2E-tests/tests/committee/test_committee.py Outdated Show resolved Hide resolved
E2E-tests/config/substrate/devnet_nodes.json Outdated Show resolved Hide resolved
E2E-tests/src/partner_chain_rpc.py Outdated Show resolved Hide resolved
E2E-tests/tests/committee/test_committee.py Outdated Show resolved Hide resolved
@ladamesny ladamesny enabled auto-merge (squash) November 27, 2024 12:16
@ladamesny ladamesny force-pushed the ETCM-8250/test-update-d-param branch 3 times, most recently from 19a7382 to 24348fb Compare November 27, 2024 13:13
@ladamesny ladamesny force-pushed the ETCM-8250/test-update-d-param branch 6 times, most recently from b37de0b to 337b02e Compare November 27, 2024 13:32
ETCM-8250 update min max of p and r

Update E2E-tests/config/api_config.py

Co-authored-by: Radosław Sporny <[email protected]>

ETCM-8250 update min max of p and r

ETCM-8250 update min max of p and r

ETCM-8250 fix parameters for udpate-d-param call

ETCM-8250 fix parameters for udpate-d-param call

ETCM-8250 add marker to update_d_param test

ETCM-8250 simplified the test code to make more readable

ETCM-8250 update readme for overrides

ETCM-8250 make d param min max optional - skip test_update_d_param if not set

fix: d_param_min and max as optional

avoid using nix derivations defined in pc-contracts repo (#272)

ETCM-8250 add marker to update_d_param test

avoid using nix derivations defined in pc-contracts repo (#272)

avoid using nix derivations defined in pc-contracts repo (#272)

avoid using nix derivations defined in pc-contracts repo (#272)
@ladamesny ladamesny merged commit 89d0e9c into master Nov 27, 2024
14 checks passed
@ladamesny ladamesny deleted the ETCM-8250/test-update-d-param branch November 27, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E2E-tests E2E Tests for SDET review/approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants